Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix finding of headers #2

Closed
wants to merge 1 commit into from
Closed

Conversation

wdconinc
Copy link

@wdconinc wdconinc commented Jan 6, 2023

GaudiCommonSvc/src/HistogramPersistencySvc/RootHistogramSink.cpp fails to find HistogramPersistencySvc/RootHistogramSinkBase.h since the corresponding include directory does not appear to get added to the build.

BEGINRELEASENOTES

  • cmake: include ${CMAKE_CURRENT_SOURCE_DIR}/include for gaudi_add_module

ENDRELEASENOTES

GaudiCommonSvc/src/HistogramPersistencySvc/RootHistogramSink.cpp fails to find HistogramPersistencySvc/RootHistogramSinkBase.h since the corresponding include directory does not appear to get added to the build.
@tmadlener
Copy link
Contributor

Sorry, I seem to have missed this earlier. Forwarded to upstream: https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1411

@tmadlener
Copy link
Contributor

This has been picked up in upstream via: https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1417

@tmadlener tmadlener closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants